Repository navigation
fix: align sidebar lesson labels with chapter labels (#217) - #229
Open
bhushan4work wants to merge 1 commit into
Open
bhushan4work wants to merge 1 commit into
bhushan4work wants to merge 1 commit into
Conversation
…#217) Closes json-schema-org#217 - .stepItem padding-left 16px -> 28px so lesson text starts at the same x-offset as chapter labels (33 margin + 1 border + 28 = 62px) - .activeStep padding-left 26px to compensate its 3px active border
Author
|
@michaelmior I would like u to review my pr for this ui fix , lemme know if any further fix is needed . thank you |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217
.stepItempadding-left from16pxto28pxso lesson labels align with chapter labels..activeSteppadding-left to26pxto account for its3pxactive border.What kind of change does this PR introduce?
Bugfix.
Issue Number:
Screenshots/videos:
The sidebar lesson labels are now aligned consistently with the chapter labels.
If relevant, did you update the documentation?
Not applicable.
Summary
Fixes the sidebar subsection alignment issue by adjusting the horizontal padding of lesson items so their labels align with the surrounding chapter labels, including active lessons.
Does this PR introduce a breaking change?
No.